Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vis-2-widgets-rssfeed to latest #3785

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add vis-2-widgets-rssfeed to latest #3785

wants to merge 2 commits into from

Conversation

oweitman
Copy link
Contributor

@oweitman oweitman commented Jul 1, 2024 •
edited
Loading

[E124] Main file not found under URL: https://raw.githubusercontent.com/oweitman/ioBroker.vis-2-widgets-rssfeed/main/widgets/vis-2-widgets-rssfeed/customWidgets.js
-> datei wird im build prozess erzeugt

[E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.vis-2-widgets-rssfeed"
-> bluefox wurde hinzugefügt und hat angenommen

[E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file
-> datei wird im build prozess erzeugt

[W400] Cannot find "vis-2-widgets-rssfeed" in latest repository
-> ja genau, hier ist es

[W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
-> für vis-2 widgets wird es noch benötigt

@oweitman
bring vis-2-widgets-rssfeed to latest
1539e55 
[E124] Main file not found under URL: https://raw.githubusercontent.com/oweitman/ioBroker.vis-2-widgets-rssfeed/main/widgets/vis-2-widgets-rssfeed/customWidgets.js
-> datei wird im build prozess erzeugt

[E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.vis-2-widgets-rssfeed"
-> bluefox wurde hinzugefügt, er hat noch nicht angenommen

[E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file
-> datei wird im build prozess erzeugt

[W400] Cannot find "vis-2-widgets-rssfeed" in latest repository
-> ja genau, hier ist es

[W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
-> für vis-2 widgets wird es noch benötigt
@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Jul 1, 2024
@mcm1957 mcm1957 changed the title bring vis-2-widgets-rssfeed to latest Add vis-2-widgets-rssfeed to latest Jul 1, 2024
@mcm1957 mcm1957 added the (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. label Jul 1, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 1, 2024 •
edited
Loading

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them.

You will find the results of the review and eventually issues / suggestings as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.

reminder 15.7.2024

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 1, 2024

[E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file can be ignored (false positive)

@github-actions github-actions bot added the 15.7.2024 remind after 15.7.2024 label Jul 1, 2024
@github-actions github-actions bot added the *📬 a new comment has been added label Jul 1, 2024
@github-actions github-actions bot deleted a comment from oweitman Jul 1, 2024
@oweitman
Copy link
Contributor Author

oweitman commented Jul 1, 2024

[W184] "common.noConfig" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI.config":"none".

und

[E114] No adapter are allowed in the repo without admin support (set "common.noConfig = true" and "common.adminUI.config = none" if adapter has no configuration)

ersteres ist etwas missverständlich formuliert. deprecated sieht so aus als ob man es entfernen sollte.

@oweitman
Copy link
Contributor Author

oweitman commented Jul 1, 2024

RE-CHECK!

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 4, 2024
@github-actions github-actions bot added the *📬 a new comment has been added label Jul 5, 2024
@github-actions github-actions bot deleted a comment from oweitman Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Automated adapter checker

ioBroker.vis-2-widgets-rssfeed

Downloads - Test and Release
NPM

  • ❗ [E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file
  • 👀 [W184] "common.noConfig" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI.config":"none".
  • 👀 [W400] Cannot find "vis-2-widgets-rssfeed" in latest repository
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
15.7.2024 remind after 15.7.2024 auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oweitman @mcm1957