-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add damping factor #131
Add damping factor #131
Conversation
adding damping factor &damping=1,0.3
Admin add damping factor setting
add variable of damping factor in main
add damping in pv section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add changelog to README
- Add damping / conversion for other providers (e.g. solcast)
- Update documentation
admin/jsonConfig.json
Outdated
"sort": false, | ||
"default": 0 | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indentation
main.js
Outdated
@@ -659,10 +659,10 @@ class Pvforecast extends utils.Adapter { | |||
if (this.config.service === 'forecastsolar') { | |||
if (this.hasApiKey) { | |||
// https://api.forecast.solar/:apikey/estimate/:lat/:lon/:dec/:az/:kwp | |||
url = `https://api.forecast.solar/${this.config.apiKey}/estimate/${this.pvLatitude}/${this.pvLongitude}/${plant.tilt}/${plant.azimuth}/${plant.peakpower}?time=utc`; | |||
url = `https://api.forecast.solar/${this.config.apiKey}/estimate/${this.pvLatitude}/${this.pvLongitude}/${plant.tilt}/${plant.azimuth}/${plant.peakpower}?time=utc&damping=${plant.dampingm},${plant.dampinge}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the config attributes are dampe
and dampm
admin/jsonConfig.json
Outdated
@@ -306,6 +306,52 @@ | |||
"filter": false, | |||
"sort": false, | |||
"default": 0 | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indentation
typo
show configuration only when forecast solar is choosen
revert change for hiden
Sorry, was too late yesterday... now I correct all typos and it should work. I would like to show the damping factor only when choose solar cast, but EDIT: |
In tables you have to use
Nothing. That's an issue with the schema validation. |
38ea1ba
into
iobroker-community-adapters:main
Add damping factor to pv tab. Quick and dirty...