Explicit parameter checking instead of taking First & Last #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2017 20:11
If opcode AND operand are not null we should go into the two-parameter constructor methods. If opcode is not null but operand is, we go into single parameter constructor method. If both are null, the app will probably crash. :D (But it already crashes on a whole lot of invalid functions anyway lol)
|
Thanks! |
|
lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If opcode AND operand are not null we should go into the two-parameter constructor methods.
If opcode is not null but operand is, we go into single parameter constructor method.
If both are null, the app will probably crash. :D (But it already crashes on a whole lot of invalid functions anyway lol)
Could add additional string value checking but bleh.