Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): update @stencil/core requirement from ^0.12.4 to ^0.13.2 in /packages/@ionic/lab #3631

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on @stencil/core to permit the latest version.

Changelog

Sourced from @stencil/core's changelog.

⚡️ 0.13.2 (2018-09-27)

Bug Fixes

  • pixelmatch: require pixelmatch within fn (36a4b37)

🐨 0.13.1 (2018-09-26)

Bug Fixes

  • resolve: ensure paths are normalized in NodeResolveModule (80fda2a)
  • screenshot: ensure pixelmatch is installed (1fba6c8)

Features

  • testing: --no-build flag to skip build before e2e testing (110ccaa)

🏁 0.13.0 (2018-09-26)

Stencil Testing Features

Testing within Stencil is now broken up into two distinct types: Unit tests with Jest, and End-to-end tests with Puppeteer. Previous versions already used Jest, but Stencil provided a TestWindow and mocked the browser environment using JSDom.

With the latest changes, the browser environment for e2e testing is done using Puppeteer, which provides many advantages Stencil can start to incorporate into its builds later on. This means the previous testing methods using TestWindow has been removed in place of Puppeteer's API.

Unit testing is for testing small chunks of code at the lowest level. For example, when a method is given X, it should return Y. Unit tests should not be doing full rendering of the component, but rather focused on logic only. E2E tests would be testing rendering and components working together. For example, when my-component has the X attribute, the child component then renders the text Y, and expects to receive the event Z. By using Puppeteer for rendering tests (rather than a Node environment simulating how a browser works), your end-to-end tests are able to run within an actual browser in order to give better results.

Stencil also provides many utility functions to help test Jest and Puppeteer. For example, a component's shadow dom can now be queried and tested with the Stencil utility functions built on top of Puppeteer. Tests can not only be provided mock HTML content, but they can also go to URLs of your app which Puppeteer is able to open up and test on Stencil's dev server.

End-to-end tests require a fresh build, dev-server, and puppeteer browser instance created before the tests can actually run. With the added build complexities, the stencil test command is able to organize the build requirements beforehand.

Previously, the jest command was directly within an npm script, and Jest's config was within the app's package.json file. While this is certainly still doable, the stencil test command handles the build requirements, keeps configurations centralized in stencil.config.ts, and lazily installs Jest and Puppeteer when they're needed for the first time.

With this release, the jest config within the app's package.json file can be safely removed, and the npm test script can be set to stencil test --spec instead of jest. It's also recommended to add an npm script test.e2e pointing to stencil test --e2e. Note that both unit tests and end-to-end tests could be ran with the same command, such as stencil test --spec --e2e. Below would be a common setup:

"scripts": {
  "test": "stencil test --spec",
  "test.watch": "stencil test --spec --watch",
  "test.e2e": "stencil test --e2e"
}
</table> ... (truncated)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Updates the requirements on [@stencil/core](https://github.com/ionic-team/stencil) to permit the latest version.
- [Release notes](https://github.com/ionic-team/stencil/releases)
- [Changelog](https://github.com/ionic-team/stencil/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ionic-team/stencil/commits/v0.13.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@imhoffd imhoffd merged commit 0729615 into develop Oct 5, 2018
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/packages/@ionic/lab/@stencil/core-tw-0.13.2 branch October 5, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants