Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vue): fix typo in useIonRouter example #2157

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

Ph0tonic
Copy link
Contributor

@Ph0tonic Ph0tonic commented Jan 9, 2022


name: Invalid variable name
about: Invalid variable name
title: The variable name for vue when using ionRouter is invalid
labels: doc, vue
assignees: ''


URL
The URL at which the content is missing or inaccurate

What is missing or inaccurate about the content on this page?

We import a ionrouter but then we use an hypothetical variable named router:
Initial :

const ionRouter = useIonRouter();
router.navigate('...');

Fixed:

const ionRouter = useIonRouter();
ionRouter.navigate('...');

@vercel
Copy link

vercel bot commented Jan 9, 2022

@Ph0tonic is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@Ph0tonic
Copy link
Contributor Author

Ph0tonic commented Mar 7, 2022

\cc @liamdebeasi Hello, any help would be welcome.

@Ph0tonic Ph0tonic changed the title Fix invalid variable name [Doc Vue] Fix: invalid variable name Mar 7, 2022
@liamdebeasi liamdebeasi changed the title [Doc Vue] Fix: invalid variable name docs(vue): fix typo in useIonRouter example Mar 7, 2022
@liamdebeasi liamdebeasi merged commit 4eaf3fd into ionic-team:main Mar 7, 2022
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants