Update FSharp.Analyzers.SDK to 0.13.0 #1163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah I started this discussion over here: ionide/FSharp.Analyzers.SDK#73 (comment) I'm probably not gonna accept any updates to the analyzer SDK while we're still making a lot of breaking changes over there. |
|
Closing in favour of #1217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 9bd005f
Improved the loading and handling of analyzers in the F# LSP servers. Refactored the
analyzerHandlerfunction to use a more suitable type.🤖 Generated by Copilot at 9bd005f
📝🛠️🚨
WHY
HOW
🤖 Generated by Copilot at 9bd005f
analyzerHandlerfunction by using theParseAndCheckResultstype instead of passing individual fields (link, link, link, link)There is no way the analyzers loaded with the current
FSharp.Analyzers.SDKcould ever work at runtime. The mismatch inFCSversion will most likely blow up for everyone.I'm trying to address this in this PR.
There is one catch though: We currently don't have the full project-type check information.
This perhaps is a bit of a too-strict requirement to load analyzers. It makes sense from the CLI point of view but maybe not for the editor.
Let me know what makes the most sense and we can act accordingly.