Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TokenSchemeDto #1314

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix TokenSchemeDto #1314

merged 1 commit into from
Mar 31, 2022

Conversation

Thoralf-M
Copy link
Member

Description of change

Fix TokenSchemeDto

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Deserialized a FoundryOutput from the hornet API

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@Thoralf-M Thoralf-M added the n-shimmer Network - Shimmer label Mar 31, 2022
@samuel-rufi samuel-rufi self-requested a review March 31, 2022 18:58
@thibault-martinez thibault-martinez added wg-message Working Group - Message c-bug Category - Bug e-medium Experience - Medium p-high Priority - High labels Mar 31, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone Mar 31, 2022
@thibault-martinez thibault-martinez merged commit 4686166 into iotaledger:shimmer-develop Mar 31, 2022
@Thoralf-M Thoralf-M deleted the fix/TokenSchemeDto branch March 31, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@pvdrz pvdrz pvdrz approved these changes

@bingyanglin bingyanglin Awaiting requested review from bingyanglin

Assignees
No one assigned
Labels
c-bug Category - Bug e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Thoralf-M @thibault-martinez @samuel-rufi @pvdrz