Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notarization and networking bugs #2417

Merged
merged 23 commits into from
Sep 5, 2022
Merged

Fix notarization and networking bugs #2417

merged 23 commits into from
Sep 5, 2022

Conversation

karimodm
Copy link
Contributor

@karimodm karimodm commented Sep 5, 2022

Description of change

This PR fixes a few bugs:

  • Notarization's storeDiffUTXOs output included multiple times in epoch.
  • "send on closed channel" when handling a closed stream.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

@karimodm
Fix: concurrent map read/write
77c52a4
@karimodm
Make notarization maps shrink
61426e8
@karimodm
Fix epochProcessBlocksCommand index out of range
54b45d7
@karimodm
shrinkable commitmentTrees
35d69c2
@karimodm
Notarization: do not commit to <0 ledgerstates
6f5378e
@karimodm
Remove "block commits to" debug log
43e7156
@karimodm
Fix: memory leak in mana GetEpochDiff
4449118
@karimodm
Disconnect neighbor on timeout error
c7eeca7
@karimodm
Reset GenesisTime
1fa9d6a
@karimodm
Revert "Disconnect neighbor on timeout error"
8268dcb 
This reverts commit c7eeca7.
@karimodm
Do not enforce deadline on PacketStream's ReadBlk
c8e2de7
@karimodm
Do not enforce deadline on PacketStream's WriteBlk
fe525bf
@karimodm
Fix: nil pointer dereference
e108380
@karimodm
Prevent OnTransactionAccepted after OnTransactionInclusionUpdated
aa3b759
@karimodm
send on closed ProtocolStream chan
07b7d6b
@karimodm
Revert "Prevent OnTransactionAccepted after OnTransactionInclusionUpd…
125c9eb 
…ated"

This reverts commit aa3b759.
@karimodm
Better solution to Prevent OnTransactionAccepted after OnTransactionI…
615f183 
…nclusionUpdated
@karimodm
Notarization test TX InclusionUpdate before Acceptance
7ef0f6f
@karimodm
Only storeDiffUTXOs if absent
4b3fd98
@karimodm
Revert "Notarization test TX InclusionUpdate before Acceptance"
ff62aac 
This reverts commit 7ef0f6f.
@karimodm karimodm changed the title Bug fixes Fix stability bugs Sep 5, 2022
@karimodm karimodm changed the title Fix stability bugs Fix notarization and networking bugs Sep 5, 2022
@karimodm karimodm temporarily deployed to feature September 5, 2022 09:59 Inactive
@karimodm karimodm temporarily deployed to feature September 5, 2022 10:53 Inactive
@karimodm karimodm temporarily deployed to feature September 5, 2022 13:44 Inactive
@karimodm karimodm merged commit e898998 into develop Sep 5, 2022
@karimodm karimodm deleted the fix/release-bugs branch September 5, 2022 13:50
This was referenced Sep 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonastheis jonastheis jonastheis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karimodm @jonastheis