Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python generate_addresses to be more Pythonic #26

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Update python generate_addresses to be more Pythonic #26

merged 8 commits into from
Apr 3, 2023

Conversation

Dr-Electron
Copy link
Contributor

@Dr-Electron Dr-Electron commented Mar 23, 2023

Description of change

This is just a cherry-pick of iotaledger/iota.rs#1651

Links to any relevant issues

Fixes #47

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

The generated json was validated with the jsonschema generated by my tool

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Dr-Electron Dr-Electron marked this pull request as ready for review March 31, 2023 13:24
@thibault-martinez thibault-martinez merged commit f1da4b2 into iotaledger:develop Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pythonic generate_addresses function
3 participants