Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output how-tos #465

Merged
merged 16 commits into from
May 24, 2023
Merged

Add output how-tos #465

merged 16 commits into from
May 24, 2023

Conversation

Dr-Electron
Copy link
Contributor

@Dr-Electron Dr-Electron commented May 22, 2023 •
edited
Loading

Description of change

Added output how-tos

Links to any relevant issues

Fixes #412 and partially #411

Type of change

  • Documentation Enhancement

How the change has been tested

Tested locally

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Dr-Electron Dr-Electron marked this pull request as ready for review May 22, 2023 09:40
Thoralf-M
Thoralf-M requested changes May 22, 2023
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust and nodejs fmt :trollface:

Thoralf-M
Thoralf-M requested changes May 22, 2023
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts 😿

Thoralf-M
Thoralf-M previously approved these changes May 22, 2023
View reviewed changes
Dr-Electron and others added 9 commits May 23, 2023 21:30
@Dr-Electron
Add output features and unlock condition examples
7afdb97
@Dr-Electron
Add docs and unify examples
e4afea0
@Dr-Electron
Format
7c43288
@Dr-Electron
Use utf8ToHex
94eb461
@Dr-Electron @Thoralf-M
Update documentation/sdk/docs/how_tos/outputs/output_unlock_condition…
f42cba4 
…s.mdx

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Dr-Electron
Run clippy
aa5bd4f
@Dr-Electron
Format
bf41823
@Dr-Electron @Thoralf-M
Update bindings/nodejs/examples/how_tos/outputs/output_features.ts
338c99e 
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Dr-Electron @Thoralf-M
Apply suggestions from code review
b7dbb7c 
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Dr-Electron and others added 7 commits May 23, 2023 21:31
@Dr-Electron
Format
050a3fd
@Dr-Electron @Thoralf-M
Apply suggestions from code review
7a67f7c 
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Dr-Electron @Thoralf-M
Update bindings/python/examples/how_tos/outputs/output_features.py
edcd8f1 
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Dr-Electron
Apply suggestions from code review
6251eb4
@Dr-Electron @Thoralf-M
Update bindings/python/examples/how_tos/outputs/output_unlock_conditi…
e253b3d 
…ons.py

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Dr-Electron
Update output_features.rs
9926418
@Dr-Electron
Update names
2c2b8a8
@thibault-martinez thibault-martinez merged commit f04570e into iotaledger:develop May 24, 2023
@Dr-Electron Dr-Electron deleted the docs/output-features branch May 24, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Output Features examples with related docs
3 participants
@Dr-Electron @thibault-martinez @Thoralf-M