Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Favicon #266

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix - Favicon #266

merged 1 commit into from
Sep 28, 2021

Conversation

lucas-tortora
Copy link
Collaborator

Description of change

  • Upgraded iota-wiki-cli to 1.3 to have the --no-overwrite flag
  • Altered gh-pages script to send the --no-overwrite flag to avoid favicon being replaced

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Locally using node 14.14

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code

@lucas-tortora
* Upgraded iota-wiki-cli to 1.3 to have the --no-overwrite flag
829e103 
* Altered gh-pages script to send the --no-overwrite flag to avoid favicon being replaced
@lucas-tortora lucas-tortora changed the title * Upgraded iota-wiki-cli to 1.3 to have the --no-overwrite flag Fix - Favicon Sep 28, 2021
charlesthompson3
charlesthompson3 approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@charlesthompson3 charlesthompson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid👌

@Dr-Electron Dr-Electron merged commit 5709b15 into iotaledger:develop Sep 28, 2021
@lucas-tortora lucas-tortora deleted the fix/favicon branch November 2, 2021 13:01
Dr-Electron pushed a commit that referenced this pull request Feb 18, 2023
@lucas-tortora
Upgrade iota-wiki-cli to 1.3 to have the --no-overwrite flag (#266)
fee18e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@charlesthompson3 charlesthompson3 charlesthompson3 approved these changes

@eike-hass eike-hass Awaiting requested review from eike-hass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucas-tortora @Dr-Electron @charlesthompson3