Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes on Python tools #2136

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

palmtenor
Copy link
Member

Mostly things caught by PEP Linter. Some of them are stylistic (like "don't catch bare exception"), but others are syntactically valid:

  • signal defined both as module name and function argument
  • Function default argument has function call
  • Undefined local variable pid should be args.pid
  • uflow_example.txt has non-ASCII character

@yonghong-song
Copy link
Collaborator

Looks good to me. Thanks!

@yonghong-song yonghong-song merged commit aaca976 into iovisor:master Jan 11, 2019
@palmtenor palmtenor deleted the tools_fix branch January 16, 2019 21:31
palexster pushed a commit to palexster/bcc that referenced this pull request Jul 7, 2019
Misc fixes on Python tools
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
Misc fixes on Python tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants