Add example of E2E testing #368
Conversation
lelgenio
force-pushed
the
add-e2e-test-example
branch
4 times, most recently
from
9caf228
to
26731ca
Compare
| wait-for-connection localhost:4444 | ||
|
|
||
| export SSL_CERT_FILE="${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt" | ||
| ${workspace}/bin/e2e_tests |
There was a problem hiding this comment.
thought (non-blocking): Oh. Interesting. I think it works, and nothing wrong with it but generally build a whole workspace for testing and other things, and then run the e2e script.
The advantage is that the test scripts work all the same both from dev env (./script/run-some-test.sh) and CI.
IMO during daily work developers shouldn't need to touch Nix for anything but entering the dev shell.
In Flakebox I even added specialized commands to make it cleaner.
There was a problem hiding this comment.
Certainly! I added a comment to highlight this.
lelgenio
force-pushed
the
add-e2e-test-example
branch
from
26731ca
to
2bab31c
Compare
|
I went ahead and added PostgreSQL to the example, just to hammer the point home that you can spin up anything together in the test. If it's too much, let me know! |
|
I didn't squash so it's easy to drop postgres if necessary |
There was a problem hiding this comment.
Looking great, thanks for adding this @lelgenio !
I don't mind having postgres in there as long as it doesn't end up making the test suite run for too long (though we can always comment it out later if it does).
Few minor nit/cleanup comments and happy to merge afterwards!
lelgenio
force-pushed
the
add-e2e-test-example
branch
from
b5d147f
to
1accb3d
Compare
Motivation
Discussion: #366
Checklist
examples/README.md