-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splice overrideToolchain #652
Conversation
Actually, on second testing, it doesn't seem there's any difference to just doing: craneLib = (crane.mkLib pkgs).overrideToolchain pkgsBuildHost.rust-bin.stable.latest.default; So it kind of seems like splicing isn't working correctly. Though I did verify that Edit: Fixed now. |
04d2598
to
ee99f5e
Compare
I should have seen this as a red flag. This works fine after working out the issues: craneLib = (crane.mkLib pkgs).overrideToolchain (p: p.rust-bin.stable.latest.default); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR, and for making it backwards compatible! Overall I think it looks good. The hoops we have to jump through to make everything work are no where near as bad as I feared so I'm okay with moving in that direction!
Going to do a little bit of my own testing and move forward from there if it looks fine
Motivation
overrideToolchain
can now accept a function used to splice the rust toolchain:I don't fully understand why the toolchain needs be offset frompkgsBuildHost
even when spliced. But this has always been the case.Fixes #648
Fixes #551
Checklist
docs/API.md
(or general documentation) with changesCHANGELOG.md