Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

ci: add gateway-confromance test suite to the CI #66

Merged
merged 11 commits into from
Mar 29, 2023
Merged

Conversation

galargh
Copy link
Collaborator

@galargh galargh commented Mar 24, 2023

Resolves #63

This PR adds https://github.com/ipfs/gateway-conformance to the CI here.

We set up Kubo backed bifrost-gateway for the tests.

We keep subdomain-gateway spec testing disabled because: https://github.com/ipfs/bifrost-gateway/actions/runs/4511354942
We keep TestGatewayCar disabled because: https://github.com/ipfs/bifrost-gateway/actions/runs/4511433301

References to ipfs/gateway-conformance will be replaced with proper release tags once we have any (i.e. once we have release process set up - ipfs/gateway-conformance#19).

@ipfs-inactive ipfs-inactive deleted a comment from welcome bot Mar 24, 2023
@hacdias
Copy link
Collaborator

hacdias commented Mar 24, 2023

@galargh I re-enabled the subdomain conformance tests. For this, I added an additional env variable so that we configure the right subdomain to "listen on" (example.com).

Additionally, I noticed the proxy tunnel tests were failing, making the conformance tests panic [please investigate why the conformance tests panic'ed]! I also fixed that on the last commit. Apparently, we did not support the CONNECT http method.

Other than that, amazing!

Copy link
Collaborator

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you @galargh!

Some questions about logistics below.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ added docs for env variables

.github/workflows/gateway-conformance.yml Outdated Show resolved Hide resolved
.github/workflows/gateway-conformance.yml Outdated Show resolved Hide resolved
@galargh
Copy link
Collaborator Author

galargh commented Mar 27, 2023

I think we should be good to merge now 😄 @hacdias @lidel I'll let you do the honours.

@aschmahmann aschmahmann mentioned this pull request Mar 27, 2023
13 tasks
Copy link
Collaborator

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, so we have more confidence in things like #61

@lidel lidel merged commit 132a62e into main Mar 29, 2023
@lidel lidel deleted the ci/gateway-conformance branch March 29, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run new gateway-conformance tests in CI
3 participants