This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
fix: single byte range prefetch #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems there is no agreement on supporting more than one byte range. This will only prefetch the first range as CAR, and use block-by-block for remaining ones. In practice, we don't expect to see more than a single range in the real world, video seeking creates a single one etc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow-up fix for #61.
Seems there is no agreement on supporting more than one byte range. This will only prefetch the first range as CAR, and use block-by-block for remaining ones.
In practice, we don't expect to see more than a single range in the real world, video seeking creates a single one etc.
(Merging so staging is ready and will show improved graphs once the other end deploys it.)