Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: meta for ipfs.get #1235

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: meta for ipfs.get #1235

wants to merge 3 commits into from

Conversation

alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Feb 7, 2020 •
edited
Loading

@alanshaw alanshaw mentioned this pull request Feb 7, 2020
Closed
3 tasks
alanshaw pushed a commit to ipfs/js-ipfs that referenced this pull request Feb 9, 2020
feat: metadata for ipfs.get
a651279 
Pack file `mtime` and `mode` if set

Depends on:

* [ ] #2758
* [ ] ipfs-inactive/js-ipfs-http-client#1235
achingbrain
achingbrain suggested changes Feb 10, 2020
View reviewed changes
src/get.js
@@ -39,15 +39,16 @@ module.exports = configure(({ ky }) => {
const extractor = Tar.extract()

for await (const { header, body } of extractor(toIterable(res.body))) {
const file = {
path: header.name,
mtime: { secs: Math.floor(header.mtime.getTime() / 1000) },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this support the nsecs mtime component too? At the moment I think it's going to throw away anything that isn't a whole second.

@achingbrain
Copy link
Collaborator

Could you merge this into ipfs/js-ipfs#2759 please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @achingbrain