This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
chore: use same hash for empty node as go #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vmx
previously approved these changes
May 19, 2018
There was a problem hiding this comment.
I just like to mention what I tell almost everybody :) I'd prefer if the things that are mentioned in the pull request description are also part of the commit message (I usually just put everything into the commit message, it will then automatically be the pull request description). This way you get all the background also from the Git history, not only from GitHub.
Though, there's no need to change this for this commit, it's just for future commits :)
|
Requires the following to be merged: |
alanshaw
approved these changes
Jun 8, 2018
Part of making the hases emitted by js-ipfs the same as go-ipfs meant unsetting the data attribute of UnixFS metadata objects if the data buffer had 0 length. ipfs.files.get converts a pull stream of files into a readable stream of files and all of the content pull streams too. If an empty buffer is not emitted by the file content pull stream for file with no data then no file is written out to the filesystem. This was a fun bug to track down. This module used to emit empty buffers for UnixFS metadata with no data property but I removed it as part of #208 as there was no test that failed without it so here we reinstate it and add a test.
achingbrain
force-pushed
the
improve-consistency-with-go
branch
from
198f1ae
to
cd570b7
Compare
achingbrain
force-pushed
the
improve-consistency-with-go
branch
from
4bba7a3
to
1a70af6
Compare
|
Mac slaves segfaulting after the tests pass, I think this is fine to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the breakage that ipfs/js-ipfs-unixfs#25 causes.