This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Add 100% test coverage. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing due to libp2p/js-libp2p-switch#50 |
Not true. Swarm updates the addrs if any was modified, as something that gets return by the listener. https://github.com/diasdavid/js-libp2p-swarm/blob/master/src/index.js#L107-L118 |
hackergrrl
force-pushed
the
coverage
branch
2 times, most recently
from
a91698b
to
537fcb1
Compare
|
done |
|
thank you 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the default behaviour of setting
peerInfoto/ip4/0.0.0.0/tcp/0when it's not provided: this object doesn't get exposed anywhere, so there's no way to know what port ended up being chosen anyway. In the interest of being explicit, an error is instead thrown.