This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
perf: use svg sprites & urls instead of all inline #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
satazor
force-pushed
the
svgs-perf
branch
2 times, most recently
from
cc13c83
to
484146b
Compare
|
I wanted to make separate PRs for everything but I had no time. Additionally, I will follow up more improvements after DWeb. |
|
@satazor merge conflicts |
satazor
force-pushed
the
svgs-perf
branch
2 times, most recently
from
7c19f1f
to
6fa57ea
Compare
|
|
|
@PedroMiguelSS can you handle the merge conflicts of this one? Hoping to see this published today. |
|
I've rebased again. Here's a screenshot of the before and after:
There's still more minor improvements to do. We need to do that as part of #69 |
|
@PedroMiguelSS can we please merge this asap to avoid more conflicts? Please review the PR carefully as there is a lot of changes. I'm sorry to not split it into more PRs but I really didn't have the time. |
10 tasks
satazor
force-pushed
the
svgs-perf
branch
2 times, most recently
from
6b887c5
to
82c906c
Compare
vasco-santos
approved these changes
Aug 9, 2018
There was a problem hiding this comment.
The code seems good to me! @PedroMiguelSS will double check and test it 🙂
satazor
force-pushed
the
svgs-perf
branch
2 times, most recently
from
5ea4ad3
to
4e25c9c
Compare
PedroMiguelSS
force-pushed
the
svgs-perf
branch
from
221bd1b
to
6da5615
Compare
- Moved images to folders closest to components, allowing for future optimizations with sprites - Renamed some files, variables and data - Fixed footer element placements - Fixed code consistenty with spaces in some files - Removed locale utils, it's not necessary at alls - Removed unused data files - Improved css modules hash in production - Improved videos sections hover animations - Fixed play icon being loaded from imgur instead of IPFS - Used standard transitions whenever possible
PedroMiguelSS
force-pushed
the
svgs-perf
branch
from
6da5615
to
ae8e2c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #69