This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
fix: exclude wikipedia published without canonical urls #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: ipfs/distributed-wikipedia-mirror#48 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/exclude-old-wiki-via-robots.txt
branch
from
September 2, 2019 19:27
81ce3ef
to
e0a083d
Compare
Kubuxu
reviewed
Sep 2, 2019
|
||
# better safe than sorry | ||
User-agent: * | ||
Disallow: /harming/humans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will work this around with 0th law. ;p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 PR welcome 🙃
jessicaschilling
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.A. approves. (Also LGTM)
olizilla
previously requested changes
Sep 4, 2019
#334 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel -- Did we reach a decision on what to to about this? |
@jessicaschilling IMO this PR is safe to merge: excludes selected wikipedia mirrors, but leaves everything else crawlable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
/robots.txt
that protect us from robots and exclude specific popular Wikipedia snapshots published withoutlink rel=canonical
(ipfs/distributed-wikipedia-mirror#48)Context: ipfs/distributed-wikipedia-mirror#48, openzim/mwoffliner#963
Closes #328