Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to libp2p 0.52 and use quick-protobuf #47

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented Jul 16, 2023

This PR updates libp2p to 0.52 (continuation of #43) as well as replacing the use of prost with quick-protobuf.

This PR also update libipld to 0.16 and multihash to 0.18

This pr supersede #43

Cargo.toml Outdated
"ed25519",
"async-std",
] }
multihash = { version = "0.17.0", default-features = false, features = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxinden to my knowledge, multihash in libp2p has been updated to 0.19, so I would assume it would be safe to update this as well? Havent checked the changes upstream so i would assume another crate would need to be imported

CC @rkuhn

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. rust-libp2p v0.52.0 uses rust-multihash v0.19.0.

https://github.com/libp2p/rust-libp2p/blob/ce9821154a3bde53e38e72c511acbacb721573ce/Cargo.lock#L3333-L3335

so I would assume it would be safe to update this as well?

I don't see any reason not to do so. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants