Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ls #1

Merged
merged 7 commits into from
Oct 22, 2018
Merged

feat: ls #1

merged 7 commits into from
Oct 22, 2018

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Oct 22, 2018 •
edited
Loading

  • Unified ls - one ls to rule them all!
  • Size is file size without protobuf wrapper TODO
  • Type is consistent and a string: "directory" or "file"
  • Output is async iterator

Alan Shaw added 7 commits October 21, 2018 22:48
feat: WIP ls
910515d 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
feat: WIP rationale and test fixes
7f4f23d 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
refactor: simplify port service and just use get-port module
2268a8f 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
docs: ls API docs and examples
6a3d3ee 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
fix: ls return type
3a8e340 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
fix: size unit
91ab01e 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
docs: add note on MFS path of same name
e48ac48 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw changed the title [WIP] feat: ls feat: ls Oct 22, 2018
@alanshaw alanshaw merged commit 586758e into master Oct 22, 2018
@alanshaw alanshaw deleted the feat/ls branch October 22, 2018 22:23
@alanshaw alanshaw mentioned this pull request Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alanshaw