feat: build opt-out for cache-node-modules action #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've used this action several times and did not know that it was also called `npm run build`. The build step can increase a workflow's runtime and complexity, and I usually don't want to do that. I think it's useful, but since there was already support for `inputs.build`, I think it's unnecessary. An opt-out (since we don't want to break existing users) will help me out a lot.
|
@SgtPooki Seems reasonable enough, do you still need this? |
Please sir |
achingbrain
approved these changes
Dec 7, 2022
achingbrain
deleted the
feature/build-opt-out-for-cache-node-modules-action
branch
|
🎉 This PR is included in version 37.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used this action several times and did not know that it was also calling
npm run build.The build step can increase a workflow's runtime and complexity, and I usually don't want to do that. I think it's useful, but since there was already support for
inputs.build, I think it's unnecessary. An opt-out (since we don't want to break existing users) will help me out a lot.