refactor: use peer.Decode for now to validate IPNS component

ipfs · May 29, 2023 · c68c5f4 · c68c5f4
1 parent d58096f
commit c68c5f4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 67 deletions.
diff --git a/gateway/handler.go b/gateway/handler.go
@@ -17,7 +17,6 @@ import (
 	"time"
 
 	ipath "github.com/ipfs/boxo/coreiface/path"
-	"github.com/ipfs/boxo/ipns"
 	cid "github.com/ipfs/go-cid"
 	logging "github.com/ipfs/go-log"
 	"github.com/libp2p/go-libp2p/core/peer"
@@ -380,7 +379,8 @@ func (i *handler) isTrustlessRequest(contentPath ipath.Path, responseFormat stri
 		}
 
 		// Only valid, cryptographically verifiable IPNS record names (no DNSLink on trustless gateways)
-		if _, err := ipns.Decode(pathComponents[1]); err != nil {
+		// TODO: replace with ipns.Name as part of https://github.com/ipfs/specs/issues/376
+		if _, err := peer.Decode(pathComponents[1]); err != nil {
 			return false
 		}
 

diff --git a/ipns/name.go b/ipns/name.go
diff --git a/ipns/name_test.go b/ipns/name_test.go