blockservice: remove busyloop in getBlocks by removing batching #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 48.13% 48.19% +0.06%
==========================================
Files 267 267
Lines 32571 32565 -6
==========================================
+ Hits 15678 15695 +17
+ Misses 15236 15218 -18
+ Partials 1657 1652 -5
|
Jorropo
force-pushed
the
blockservice-millions-of-block-notifies
branch
from
2cd198b
to
8efc0a4
Compare
Jorropo
changed the title
Jorropo
force-pushed
the
blockservice-millions-of-block-notifies
branch
2 times, most recently
from
1cfd8cb
to
9289f0e
Compare
Jorropo
changed the title
It makes the code quite more complex and there is no evidance it helps for anything.
Jorropo
force-pushed
the
blockservice-millions-of-block-notifies
branch
from
9289f0e
to
1c17d52
Compare
Jorropo
force-pushed
the
blockservice-millions-of-block-notifies
branch
2 times, most recently
from
890701e
to
1c17d52
Compare
MichaelMure
approved these changes
Mar 29, 2023
guseggert
approved these changes
Mar 29, 2023
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes the code quite more complex and there is no evidance it helps for anything.
This reduce the CPU usage of
ipfs get(and other code that use the blockservicegetBlocks) by ~7x (from 200% CPU usage to 30%).