feat: switch gateway GetRange API to match Get #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes serving range requests for /ipfs/bafydir when we know we'll get the index.html or _redirect.
aschmahmann
force-pushed
the
feat/gateway-fix-range-dir
branch
from
ff460b5
to
3867a1a
Compare
aschmahmann
commented
Mar 30, 2023
| // data, however consumers of this function may require extra data beyond the passed ranges (e.g. the initial bit of | ||
| // the file might be used for content type sniffing even if only the end of the file is requested). | ||
| // Note: there is currently no semantic meaning attached to a range request for a directory | ||
| GetRange(context.Context, ImmutablePath, ...GetRange) (ContentPathMetadata, *GetResponse, error) |
There was a problem hiding this comment.
Looking at the code now, should we just have a single function Get(context.Context, ImmutablePath, ...GetRange) (ContentPathMetadata, *GetResponse, error) and drop GetRange entirely (since passing no ranges is equivalent to asking for the entire object)?
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 47.70% 48.01% +0.30%
==========================================
Files 266 269 +3
Lines 32950 32957 +7
==========================================
+ Hits 15718 15823 +105
+ Misses 15549 15466 -83
+ Partials 1683 1668 -15
|
2 tasks
|
I've cherry-picked this into #245, will continue there, Incl. |
3 tasks
lidel
added a commit
that referenced
this pull request
Mar 31, 2023
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 1, 2023
hacdias
pushed a commit
that referenced
this pull request
Apr 3, 2023
hacdias
pushed a commit
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes serving range requests for /ipfs/bafydir when we know we'll get the index.html or _redirect.
cc ipfs-inactive/bifrost-gateway#61