Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example): simplify ipns validation #306

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 17, 2023

Forgot to update in #294.

I will merge this right away if tests pass. Extremely simple and already tested by other code.

@hacdias hacdias requested a review from lidel as a code owner May 17, 2023 13:11
@hacdias hacdias self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #306 (205b3e5) into main (ff20a4d) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   48.04%   48.11%   +0.06%     
==========================================
  Files         279      279              
  Lines       33497    33487      -10     
==========================================
+ Hits        16095    16111      +16     
+ Misses      15715    15692      -23     
+ Partials     1687     1684       -3     
Impacted Files Coverage Δ
examples/gateway/proxy/routing.go 12.98% <0.00%> (+1.49%) ⬆️

... and 8 files with indirect coverage changes

@hacdias hacdias merged commit 4fb455d into main May 17, 2023
@hacdias hacdias deleted the ref/ex-simplify-ipns branch June 27, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant