Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing/http): delegated IPNS server and client, IPIP 379 #333

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jun 5, 2023

@hacdias hacdias self-assigned this Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #333 (59d1001) into main (aa7add0) will increase coverage by 0.07%.
The diff coverage is 51.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   49.74%   49.82%   +0.07%     
==========================================
  Files         249      249              
  Lines       29994    30125     +131     
==========================================
+ Hits        14920    15009      +89     
- Misses      13645    13671      +26     
- Partials     1429     1445      +16     
Files Changed Coverage Δ
routing/http/server/server.go 60.91% <49.35%> (-4.31%) ⬇️
routing/http/client/client.go 72.98% <55.55%> (-4.86%) ⬇️

... and 10 files with indirect coverage changes

@hacdias hacdias force-pushed the ipip-379 branch 3 times, most recently from b8a0ddb to 3402424 Compare June 5, 2023 13:22
@hacdias hacdias requested a review from lidel June 5, 2023 13:23
@hacdias hacdias marked this pull request as ready for review June 5, 2023 13:23
@hacdias hacdias requested a review from a team as a code owner June 5, 2023 13:23
@hacdias hacdias changed the title feat(routing/http): delegated IPNS server, IPIP 379 feat(routing/http): delegated IPNS server and client, IPIP 379 Jun 6, 2023
@hacdias
Copy link
Member Author

hacdias commented Jun 14, 2023

Note that this PR will have to be rebased if #339 is merged first.

routing/http/client/client.go Outdated Show resolved Hide resolved
routing/http/client/client_test.go Outdated Show resolved Hide resolved
routing/http/server/server.go Outdated Show resolved Hide resolved
@hacdias
Copy link
Member Author

hacdias commented Jun 15, 2023

I will address the feedback once we have the IPNS PRs complete then (or I might rebase it earlier if I have time).

@hacdias
Copy link
Member Author

hacdias commented Jun 16, 2023

I rebased this on top of the IPNS PR to make the required changes. This also depends on a fix of go-ipld-prime, otherwise the mocking tests will fail due to an inconsistent behaviour between creating new integer nodes and decoding integer nodes: ipld/go-ipld-prime#525.

Gateway sharness will fail until IPNS PR is merged.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing tests, small nits below.

examples/go.mod Outdated Show resolved Hide resolved
routing/http/server/server_test.go Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Aug 9, 2023

ipld/go-ipld-prime#534

will get this out tomorrow unless something gets in the way

@hacdias
Copy link
Member Author

hacdias commented Aug 10, 2023

@lidel we now have a new release of go-ipld-prime (thanks @rvagg) so I think this is ready for final review.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias, I think its good enough to merge and iterate further in #422 + ipfs/kubo#9877.

ps. on windows TestClientOverMax is flaky, i've re-run it.

@hacdias hacdias merged commit f061418 into main Aug 22, 2023
13 checks passed
@hacdias hacdias deleted the ipip-379 branch August 22, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants