Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bitswap/client): add additional tracing #615

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Jun 7, 2024

This is an attempt at adding some more visibility to the Bitswap tracing code path. This overall looks to be a good improvement, but I would expect the shape of the tracing (e.g. spans vs events, granularity and names of spans/events, etc.) to change over time here and don't think we want to commit to documenting each of those changes.

I'm labeling as skip/changelog, but happy to add some info if it makes sense.

Feedback definitely welcome 🙏

@aschmahmann aschmahmann requested a review from a team as a code owner June 7, 2024 20:41
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.77%. Comparing base (4f2d250) to head (b1da22c).

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   59.77%   59.77%           
=======================================
  Files         238      238           
  Lines       29943    29979   +36     
=======================================
+ Hits        17898    17920   +22     
- Misses      10429    10439   +10     
- Partials     1616     1620    +4     
Files Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 88.21% <100.00%> (+1.07%) ⬆️
bitswap/client/internal/session/session.go 91.15% <100.00%> (+0.09%) ⬆️

... and 10 files with indirect coverage changes

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, LGTM

bitswap/client/internal/session/session.go Outdated Show resolved Hide resolved
@aschmahmann aschmahmann merged commit d99b7e8 into main Jun 20, 2024
15 checks passed
@aschmahmann aschmahmann deleted the feat/more-bitswap-tracing branch June 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants