feat(routing/http/client): DefaultProtocolFilter for IPIP-484 #689
+63
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/ipip-484-implicit-protocol-filter
branch
from
47928d1
to
bda1247
Compare
lidel
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #689 +/- ##
==========================================
+ Coverage 60.29% 60.31% +0.02%
==========================================
Files 243 243
Lines 31018 31019 +1
==========================================
+ Hits 18702 18710 +8
+ Misses 10649 10645 -4
+ Partials 1667 1664 -3
|
2color
reviewed
Oct 16, 2024
| @@ -25,15 +25,15 @@ func TestFindProviders(t *testing.T) { | |||
| if r.URL.Path == "/routing/v1/providers/"+cidStr { | |||
| w.Header().Set("Content-Type", "application/x-ndjson") | |||
| w.Write([]byte(`{"Schema":"peer","ID":"12D3KooWM8sovaEGU1bmiWGWAzvs47DEcXKZZTuJnpQyVTkRs2Vn","Addrs":["/ip4/111.222.222.111/tcp/5734"],"Protocols":["transport-bitswap"]}` + "\n")) | |||
| w.Write([]byte(`{"Schema":"peer","ID":"12D3KooWB6RAWgcmHAP7TGEGK7utV2ZuqSzX1DNjRa97TtJ7139n","Addrs":["/ip4/127.0.0.1/tcp/5734"],"Protocols":["transport-horse"]}` + "\n")) | |||
There was a problem hiding this comment.
Perhaps keep "transport-horse" and add an additional unknown one so that it's clear it's getting filtered
2color
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
routing/http/clientinitialize with implicit default protocol filter from IPIP-484 set tounknown+transport-bitswap, matching what we explicitly set in Kubo (ipfs/kubo#10534) and Rainbow (ipfs/rainbow#173).Rationale
boxo users can change or disable default filter via
WithProtocolFilteroption, but the default should be filter that is optimized for golden path, which currently means bitswap. Processing peers that we know only support unsupported protocols is wasting resources and we should skip them.Over time, we may add new protocols like http to boxo, and we will also adjust the default list accordingly.
TODO
routing/http/clientto useDefaultProtocolFilterexamples/routing/delegated-routing-clientto reflect implicit defaults