Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the IPFS org JavaScript projects guidelines #111

Merged
merged 23 commits into from
Apr 20, 2016
Merged

Update the IPFS org JavaScript projects guidelines #111

merged 23 commits into from
Apr 20, 2016

Conversation

daviddias
Copy link
Member

@jbenet jbenet added the status/in-progress In progress label Mar 20, 2016
@dignifiedquire dignifiedquire mentioned this pull request Mar 20, 2016
Closed
@RichardLitt
Copy link
Member

Who is this assigned to?

@dignifiedquire
Copy link
Member

Who is this assigned to?

To meeeee
giphy-5

@daviddias
Copy link
Member Author

@RichardLitt It is a WIP while we get js-ipfs-api with all the tooling set up so that we can use it as a project example.

Then we will need for your help in reviewing the document itself :)

@daviddias daviddias mentioned this pull request Mar 22, 2016
Closed
This was referenced Mar 24, 2016
Closed
Merged
@daviddias daviddias closed this Mar 27, 2016
@jbenet jbenet removed the status/in-progress In progress label Mar 27, 2016
@daviddias daviddias reopened this Mar 27, 2016
@jbenet jbenet added the status/in-progress In progress label Mar 27, 2016
@daviddias daviddias changed the title write down all the notes from the discussion with Friedel and Nathan on a spec/guidelines format Update the IPFS org JavaScript projects guidelines Mar 27, 2016
@daviddias daviddias mentioned this pull request Mar 28, 2016
Closed
@daviddias
Copy link
Member Author

@RichardLitt I've just give me review on #f66ce1b, could you do a proof read so that we can merge this?

@RichardLitt
Copy link
Member

Don't merge this yet. I'm going to do a PR against it.

@daviddias daviddias force-pushed the update/js-project-guidelines branch from 7556b9e to 73d2014 Compare March 31, 2016 22:01
@daviddias daviddias force-pushed the update/js-project-guidelines branch from 73d2014 to 40b278d Compare March 31, 2016 22:06
@daviddias
Copy link
Member Author

@RichardLitt sounds good, I've updated it quite a bit too :)

@RichardLitt RichardLitt mentioned this pull request Apr 7, 2016
Closed
@dignifiedquire
Copy link
Member

@diasdavid @RichardLitt can we get this merged?

@dignifiedquire dignifiedquire mentioned this pull request Apr 13, 2016
Closed
@dignifiedquire
Copy link
Member

Need to add an .npmignore note to avoid the issues we had with .gitignore

@RichardLitt
Copy link
Member

Needs to merge #117 before merging into master. Discussion of #117 can happen on #117.

@RichardLitt
Copy link
Member

Merged my edits. @dignifiedquire -- add an .npmignore section?

@daviddias
Copy link
Member Author

So, other than the .npmignore, we are good to merge?

@dignifiedquire
Copy link
Member

Missing the notes about coveralls setup as well

@RichardLitt
Copy link
Member

@dignifiedquire Can you add those?

@daviddias
Copy link
Member Author

all the ignores are there (thank you @dignifiedquire )

Are we ready to merge? :D

@daviddias daviddias mentioned this pull request Apr 18, 2016
Closed
@RichardLitt RichardLitt merged commit d80443f into master Apr 20, 2016
@RichardLitt RichardLitt deleted the update/js-project-guidelines branch April 20, 2016 17:47
@jbenet jbenet removed the status/in-progress In progress label Apr 20, 2016
@RichardLitt
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daviddias @RichardLitt @dignifiedquire @jbenet