Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken redirect that was _exception #89

Closed
lidel opened this issue Mar 6, 2021 · 0 comments · Fixed by #90
Closed

Broken redirect that was _exception #89

lidel opened this issue Mar 6, 2021 · 0 comments · Fixed by #90
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws) snapshots issues related to snapshot creation and updates

Comments

@lidel
Copy link
Member

lidel commented Mar 6, 2021 •
edited
Loading

This was found during #61

There is an edge case when exception was resolved by moving _exception/FOO to wiki/BAR/index.html AND it is a redirect at the same time.

While we adjust src and href attributes on regular pages, we do not fix redirect HTML, which produces error by pointing at file one level too deep.

Example:

$ curl https://bafybeiehlicfvvqhauuxyj7ghspu63uv7vlq224aqytcfv5frewve5jxoq.ipfs.dweb.link/wiki/United_States_of_America/
<!DOCTYPE html><html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"><meta http-equiv="refresh" content="0;url=United_States"></head><body></body></html>

Fix is to tweak url inside of content attr and adjust it the same way we do href
@lidel lidel added kind/bug A bug in existing code (including security flaws) snapshots issues related to snapshot creation and updates labels Mar 6, 2021
@lidel lidel self-assigned this Mar 6, 2021
@lidel lidel mentioned this issue Mar 7, 2021
Closed
9 tasks
lidel added a commit that referenced this issue Mar 9, 2021
@lidel
fix: redirects converted from _exceptions
ec01bdc 
Closes #89
@lidel lidel mentioned this issue Mar 9, 2021
Merged
@lidel lidel closed this as completed in #90 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws) snapshots issues related to snapshot creation and updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: redirects converted from _exceptions ipfs/distributed-wikipedia-mirror
1 participant
@lidel