Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grant shipyard admin to rainbow repo #205

Merged
merged 4 commits into from
May 23, 2024
Merged

grant shipyard admin to rainbow repo #205

merged 4 commits into from
May 23, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented May 22, 2024

Summary

I need admin to adjust required_status_checks to new value due to change of test in ipfs/rainbow#117

Why do you need this?

Right now, can't merge PR because it requires test that no longer exists:

2024-05-23_01-51

(we replaced this with matrix that runs 3 variants)

cc @hacdias for visibility

What else do we need to know?

Is there a better way of doing this? I'm hesitant guessing what strings should be put in required_status_checks, so editing via Github GUI feels safer.

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@lidel lidel requested review from a team as code owners May 22, 2024 23:56
@lidel lidel requested a review from laurentsenta May 22, 2024 23:56
Copy link
Contributor

github-actions bot commented May 22, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User 2color:
  - will have the permission to rainbow change from push to admin
User biglep:
  - will have the permission to rainbow change from push to admin
User galargh:
  - will have the permission to rainbow change from push to admin
User guillaumemichel:
  - will have the permission to rainbow change from push to admin
User guseggert:
  - will have the permission to rainbow change from push to admin
User hacdias:
  - will have the permission to rainbow change from push to admin
User jorropo:
  - will have the permission to rainbow change from push to admin
User laurentsenta:
  - will have the permission to rainbow change from push to admin
User lidel:
  - will have the permission to rainbow change from push to admin
User marcopolo:
  - will have the permission to rainbow change from push to admin
User sgtpooki:
  - will have the permission to rainbow change from push to admin
User whizzzkid:
  - will have the permission to rainbow change from push to admin

@Stebalien
Copy link
Member

I think you need to remove yourself from "members" first.

@Stebalien
Copy link
Member

Wait, no, this is just a per-repo thing. NVM.

@lidel lidel changed the title grant lidel admin to rainbow repo grant shipyard admin to rainbow repo May 22, 2024
@lidel
Copy link
Member Author

lidel commented May 23, 2024

Yep, it is just for specific repo. Simplified and made rainbow/someguy do the same thing we do for bifrost-gateway.

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_team_repository.this["ipdx:rainbow"] will be updated in-place
  ~ resource "github_team_repository" "this" {
        id         = "6349983:rainbow"
      ~ permission = "push" -> "admin"
        # (3 unchanged attributes hidden)
    }

  # github_team_repository.this["kubo maintainers:rainbow"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rainbow"
      + team_id    = "6744049"
    }

  # github_team_repository.this["kubo maintainers:someguy"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "someguy"
      + team_id    = "6744049"
    }

  # github_team_repository.this["w3dt-stewards:rainbow"] will be updated in-place
  ~ resource "github_team_repository" "this" {
        id         = "4656983:rainbow"
      ~ permission = "push" -> "admin"
        # (3 unchanged attributes hidden)
    }

Plan: 2 to add, 2 to change, 0 to destroy.

Comment on lines +5840 to 5841
- kubo maintainers
- w3dt-stewards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but FYI it looks like the kubo-maintainers group is a strict subset of the w3dt-stewards group. Did you mean to add both?

Side note: w3dt-stewards is probably too big (and of course is a highly dated name) but can tackle that in another PR.

Copy link
Member Author

@lidel lidel May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i blindly replicated what we already had in similar repo.
cleaning up these teams will be something for a future PR.

@lidel lidel merged commit 117d0f7 into master May 23, 2024
6 checks passed
@lidel lidel deleted the lidel-patch-1 branch May 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants