-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore non-directories in the top level directory. #7
Conversation
Coverage increased (+1.5%) to 61.935% when pulling 9e8816958a3b094045102f4a1640f5739062572d on kevina/non-file-ignore into 1db836c on master. |
9e88169
to
b1e7324
Compare
@@ -343,6 +343,8 @@ func testQuerySimple(dirFunc mkShardFunc, t *testing.T) { | |||
temp, cleanup := tempdir(t) | |||
defer cleanup() | |||
|
|||
ioutil.WriteFile(filepath.Join(temp, "README"), []byte("something"), 0666) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to check that this doesnt error, just in case (if it errors and fails to create the file, then the test would pass regardless of the above fix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, oversight on my part sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed now.
Ignore non-directories in the top level directory to allow placing a README or similar file there.
b1e7324
to
7ec19f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ignore non-directories in the top level directory to allow placing a README or similar file there.
This is based on #6.