Skip to content

Commit

Permalink
Update impl/graphsync_test.go per @rvagg
Browse files Browse the repository at this point in the history
Co-authored-by: Rod Vagg <rod@vagg.org>
  • Loading branch information
hannahhoward and rvagg committed Dec 16, 2021
1 parent 985893d commit fb86ecc
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions impl/graphsync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -979,12 +979,13 @@ func TestNetworkDisconnect(t *testing.T) {

tracing := collectTracing(t)
traceStrings := tracing.TracesToStrings()
require.Contains(t, traceStrings, "response(0)->executeTask(0)")
require.Contains(t, traceStrings, "response(0)->abortRequest(0)")
require.NotContains(t, traceStrings, "response(0)->abortRequest(1)")
// may contain multiple abortRequest traces as the network error can bubble up >1 times
// but these will only record if the request is still executing
require.Contains(t, traceStrings, "request(0)->newRequest(0)")
require.ElementsMatch(t, []string{
"response(0)->executeTask(0)",
"response(0)->abortRequest(1)",
"request(0)->newRequest(0)",
"request(0)->executeTask(0)",
"request(0)->terminateRequest(0)",
}, tracing.TracesToStrings())
require.Contains(t, traceStrings, "request(0)->executeTask(0)")
require.Contains(t, traceStrings, "request(0)->terminateRequest(0)")
// has ContextCancelError exception recorded in the right place
Expand Down

0 comments on commit fb86ecc

Please sign in to comment.