Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Requests #63

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Update Requests #63

merged 7 commits into from
Apr 21, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Implement ipld/specs#258, support a pause/resume flow through hooks

Implementation

  • update the protobuf and the message structure
  • allow repsonse hooks to update the original requests
  • refactor all hooks to be consistent across requestor/responder
  • support update received hooks on the responder to support updating
    • note: we have two modes of operation here
      • request paused
        • process updates immediately, possibly unpause request
      • request in progress
        • queue updates to processed at the next block boundary

Not Addressed: functionality to apply updates to modify the original request -- it makes sense that this may be something we want to do, but exactly what it looks like is a bit nebulous, so I'm not trying to figure out the exact right approach now

@hannahhoward hannahhoward force-pushed the feat/pause-requests branch 2 times, most recently from 6284ce1 to e42842b Compare April 21, 2020 22:22
@hannahhoward
feat(graphsync): add update to message
8399237 
add update to message protobuf. also fix deserialization error with cancel requests
@hannahhoward
feat(requestmanager): support updates for response hooks
41f3575 
Support sending request updates in incoming response hooks. Also factor hooks out of request manager
@hannahhoward
refactor(hooks): make hooks approach consistent
198cf8f 
for ease of use and learning in library, make hooks structure consistent across requestor and
responder
@hannahhoward
feat(responsemanager): update request processing
aeea8db 
Add the ability to processing update requests as needed
@hannahhoward
test(responsemanager): add more tests for update behavior
afe1931
@hannahhoward
test(integration):add update integration test
876fba6 
Add test to verify the whole update flow
@hannahhoward
fix(lint): fix lint error
dfcd677
@hannahhoward hannahhoward changed the base branch from feat/pause-requests to master April 21, 2020 23:27
@hannahhoward hannahhoward merged commit 9ada784 into master Apr 21, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
@mvdan mvdan deleted the feat/update-requests branch December 15, 2021 14:15
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
@Stebalien
Update cbor-gen (#63)
b03ced0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hannahhoward