This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
fix: lazy load version, build correct multipart #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Jorropo
previously requested changes
Aug 17, 2023
There was a problem hiding this comment.
I think you should hoist:
err = s.loadRemoteVersion()
if err != nil {
return err
}
fileReader := files.NewMultiFileReader(slf, true, s.version.LT(encodedAbsolutePathVersion))In a private method of the shell that returns a file Reader and an error.
Except than this LGTM
hacdias
force-pushed
the
go-1.20-fix
branch
2 times, most recently
from
6328245
to
8860c35
Compare
Jorropo
reviewed
Aug 22, 2023
Comment on lines
+133
to
+151
| func (s *Shell) loadRemoteVersion() error { | ||
| if s.version == nil { | ||
| version, _, err := s.Version() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| remoteVersion, err := semver.New(version) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| s.versionOnce.Do(func() { | ||
| s.version = remoteVersion | ||
| }) | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
I'm pretty sure the .Do should englobe all of loadRemoteVersion's body.
Because this code will concurrently request the version number but save it only once, this leads to a data race between your s.version == nil and s.version = remoteVersion.
There was a problem hiding this comment.
I'll fix in separate PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/kubo#10068.
Will be released in subsequent PR.