This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
pubsub/pub TCP未关闭 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use english language for communication in issues/pull requests and for commit messages |
|
不错，谢谢 (not bad, thanks) |
Kubuxu
reviewed
Jul 3, 2017
| } | ||
| defer func(){ | ||
| err1 := resp.Close() |
There was a problem hiding this comment.
What if resp is nil when it errors out?
It will panic.
There was a problem hiding this comment.
I think if resp is nil, err will have to be non-nil and it'll already have returned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
导致长时间运行,大量TCP未关闭，程序失效