sync: update CI config files

.github/workflows/automerge.yml

@@ -0,0 +1,53 @@
+# File managed by web3-bot. DO NOT EDIT.
+# See https://github.com/protocol/.github/ for details.
+
+# Automatically merge pull requests opened by web3-bot, as soon as (and only if) all tests pass.
+# This reduces the friction associated with updating with our workflows.
+
+on: [ pull_request ]
+name: Automerge
+
+jobs:
+  automerge-check:
+    if: github.event.pull_request.user.login == 'web3-bot'
+    runs-on: ubuntu-latest
+    outputs:
+      status: ${{ steps.should-automerge.outputs.status }}
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        fetch-depth: 0
+    - name: Check if we should automerge
+      id: should-automerge
+      run: |
+        for commit in $(git rev-list --first-parent origin/${{ github.event.pull_request.base.ref }}..${{ github.event.pull_request.head.sha }}); do
+          committer=$(git show --format=$'%ce' -s $commit)
+          echo "Committer: $committer"
+          if [[ "$committer" != "web3-bot@users.noreply.github.com" ]]; then
+            echo "Commit $commit wasn't committed by web3-bot, but by $committer."
+            echo "::set-output name=status::false"
+            exit
+          fi
+        done
+        echo "::set-output name=status::true"
+  automerge:
+    needs: automerge-check
+    runs-on: ubuntu-latest
+    # The check for the user is redundant here, as this job depends on the automerge-check job,
+    # but it prevents this job from spinning up, just to be skipped shortly after.
+    if: github.event.pull_request.user.login == 'web3-bot' && needs.automerge-check.outputs.status == 'true'
+    steps:
+    - name: Wait on tests
+      uses: lewagon/wait-on-check-action@bafe56a6863672c681c3cf671f5e10b20abf2eaa # v0.2
+      with:
+        ref: ${{ github.event.pull_request.head.sha }}
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        wait-interval: 10
+        running-workflow-name: 'automerge' # the name of this job
+    - name: Merge PR
+      uses: pascalgn/automerge-action@741c311a47881be9625932b0a0de1b0937aab1ae # v0.13.1
+      env:
+        GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+        MERGE_LABELS: ""
+        MERGE_METHOD: "squash"
+        MERGE_DELETE_BRANCH: true

.github/workflows/go-check.yml

@@ -0,0 +1,74 @@
+# File managed by web3-bot. DO NOT EDIT.
+# See https://github.com/protocol/.github/ for details.
+
+on: [push, pull_request]
+name: Go Checks
+
+jobs:
+  unit:
+    runs-on: ubuntu-latest
+    name: All
+    env:
+      RUNGOGENERATE: false
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions/setup-go@v2
+        with:
+          go-version: "1.17.x"
+      - name: Run repo-specific setup
+        uses: ./.github/actions/go-check-setup
+        if: hashFiles('./.github/actions/go-check-setup') != ''
+      - name: Read config
+        if: hashFiles('./.github/workflows/go-check-config.json') != ''
+        run: |
+          if jq -re .gogenerate ./.github/workflows/go-check-config.json; then
+            echo "RUNGOGENERATE=true" >> $GITHUB_ENV
+          fi
+      - name: Install staticcheck
+        run: go install honnef.co/go/tools/cmd/staticcheck@df71e5d0e0ed317ebf43e6e59cf919430fa4b8f2 # 2021.1.1 (v0.2.1)
+      - name: Check that go.mod is tidy
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: |
+            go mod tidy
+            if [[ -n $(git ls-files --other --exclude-standard --directory -- go.sum) ]]; then
+              echo "go.sum was added by go mod tidy"
+              exit 1
+            fi
+            git diff --exit-code -- go.sum go.mod
+      - name: gofmt
+        if: ${{ success() || failure() }} # run this step even if the previous one failed
+        run: |
+          out=$(gofmt -s -l .)
+          if [[ -n "$out" ]]; then
+            echo $out | awk '{print "::error file=" $0 ",line=0,col=0::File is not gofmt-ed."}'
+            exit 1
+          fi
+      - name: go vet
+        if: ${{ success() || failure() }} # run this step even if the previous one failed
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: go vet ./...
+      - name: staticcheck
+        if: ${{ success() || failure() }} # run this step even if the previous one failed
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: |
+            set -o pipefail
+            staticcheck ./... | sed -e 's@\(.*\)\.go@./\1.go@g'
+      - name: go generate
+        uses: protocol/multiple-go-modules@v1.2
+        if: (success() || failure()) && env.RUNGOGENERATE == 'true'
+        with:
+          run: |
+            git clean -fd # make sure there aren't untracked files / directories
+            go generate ./...
+            # check if go generate modified or added any files
+            if ! $(git add . && git diff-index HEAD --exit-code --quiet); then
+              echo "go generated caused changes to the repository:"
+              git status --short
+              exit 1
+            fi
+

.github/workflows/go-test.yml

@@ -0,0 +1,55 @@
+# File managed by web3-bot. DO NOT EDIT.
+# See https://github.com/protocol/.github/ for details.
+
+on: [push, pull_request]
+name: Go Test
+
+jobs:
+  unit:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ "ubuntu", "windows", "macos" ]
+        go: [ "1.16.x", "1.17.x" ]
+    env:
+      COVERAGES: ""
+    runs-on: ${{ matrix.os }}-latest
+    name: ${{ matrix.os}} (go ${{ matrix.go }})
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go }}
+      - name: Go information
+        run: |
+          go version
+          go env
+      - name: Run repo-specific setup
+        uses: ./.github/actions/go-test-setup
+        if: hashFiles('./.github/actions/go-test-setup') != ''
+      - name: Run tests
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: go test -v -coverprofile module-coverage.txt ./...
+      - name: Run tests (32 bit)
+        if: ${{ matrix.os != 'macos' }} # can't run 32 bit tests on OSX.
+        uses: protocol/multiple-go-modules@v1.2
+        env:
+          GOARCH: 386
+        with:
+          run: go test -v ./...
+      - name: Run tests with race detector
+        if: ${{ matrix.os == 'ubuntu' }} # speed things up. Windows and OSX VMs are slow
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: go test -v -race ./...
+      - name: Collect coverage files
+        shell: bash
+        run: echo "COVERAGES=$(find . -type f -name 'module-coverage.txt' | tr -s '\n' ',' | sed 's/,$//')" >> $GITHUB_ENV
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@51d810878be5422784e86451c0e7c14e5860ec47 # v2.0.2
+        with:
+          files: '${{ env.COVERAGES }}'
+          env_vars: OS=${{ matrix.os }}, GO=${{ matrix.go }}

cli/error_posix.go

@@ -1,4 +1,5 @@
-//+build !windows,!plan9
+//go:build !windows && !plan9
+// +build !windows,!plan9
 
 package cli
 

cli/error_windows.go

@@ -1,4 +1,5 @@
-//+build windows
+//go:build windows
+// +build windows
 
 package cli
 

cli/parse_test.go

@@ -7,7 +7,7 @@ import (
 	"io/ioutil"
 	"net/url"
 	"os"
-	"path"
+	"path/filepath"
 	"strings"
 	"testing"
 
@@ -105,8 +105,8 @@ func TestOptionParsing(t *testing.T) {
 			cmds.DelimitedStringsOption(",", "delimstrings", "d", "comma delimited string array"),
 		},
 		Subcommands: map[string]*cmds.Command{
-			"test": &cmds.Command{},
-			"defaults": &cmds.Command{
+			"test": {},
+			"defaults": {
 				Options: []cmds.Option{
 					cmds.StringOption("opt", "o", "an option").WithDefault("def"),
 				},
@@ -265,7 +265,7 @@ func TestDefaultOptionParsing(t *testing.T) {
 
 	cmd := &cmds.Command{
 		Subcommands: map[string]*cmds.Command{
-			"defaults": &cmds.Command{
+			"defaults": {
 				Options: []cmds.Option{
 					cmds.StringOption("string", "s", "a string").WithDefault("foo"),
 					cmds.StringsOption("strings1", "a", "a string array").WithDefault([]string{"foo"}),
@@ -435,18 +435,18 @@ func TestBodyArgs(t *testing.T) {
 					cmds.StringArg("a", true, true, "some arg").EnableStdin(),
 				},
 			},
-			"stdinenabled2args": &cmds.Command{
+			"stdinenabled2args": {
 				Arguments: []cmds.Argument{
 					cmds.StringArg("a", true, false, "some arg"),
 					cmds.StringArg("b", true, true, "another arg").EnableStdin(),
 				},
 			},
-			"stdinenablednotvariadic": &cmds.Command{
+			"stdinenablednotvariadic": {
 				Arguments: []cmds.Argument{
 					cmds.StringArg("a", true, false, "some arg").EnableStdin(),
 				},
 			},
-			"stdinenablednotvariadic2args": &cmds.Command{
+			"stdinenablednotvariadic2args": {
 				Arguments: []cmds.Argument{
 					cmds.StringArg("a", true, false, "some arg"),
 					cmds.StringArg("b", true, false, "another arg").EnableStdin(),
@@ -763,7 +763,7 @@ func TestFileArgs(t *testing.T) {
 	tmpFile1 := mkTempFile(t, "", "", "test1")
 	tmpFile2 := mkTempFile(t, tmpDir1, "", "toBeIgnored")
 	tmpFile3 := mkTempFile(t, tmpDir1, "", "test3")
-	ignoreFile := mkTempFile(t, tmpDir2, "", path.Base(tmpFile2.Name()))
+	ignoreFile := mkTempFile(t, tmpDir2, "", filepath.Base(tmpFile2.Name()))
 	tmpHiddenFile := mkTempFile(t, tmpDir1, ".test_hidden_file_*", "test")
 	defer func() {
 		for _, f := range []string{
@@ -790,27 +790,27 @@ func TestFileArgs(t *testing.T) {
 			parseErr: fmt.Errorf("argument %q is required", "path"),
 		},
 		{
-			cmd: words{"fileOp", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
+			cmd: words{"fileOp", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: fmt.Errorf(notRecursiveFmtStr, tmpDir1, "r"),
 		},
 		{
-			cmd: words{"fileOp", tmpFile1.Name(), "--ignore", path.Base(tmpFile2.Name()), "--ignore"}, f: nil,
+			cmd: words{"fileOp", tmpFile1.Name(), "--ignore", filepath.Base(tmpFile2.Name()), "--ignore"}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: fmt.Errorf("missing argument for option %q", "ignore"),
 		},
 		{
-			cmd: words{"fileOp", "-r", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
+			cmd: words{"fileOp", "-r", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: nil,
 		},
 		{
-			cmd: words{"fileOp", "--hidden", "-r", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
+			cmd: words{"fileOp", "--hidden", "-r", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name(), tmpHiddenFile.Name()},
 			parseErr: nil,
 		},
 		{
-			cmd: words{"fileOp", "-r", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name(), "--ignore", "anotherRule"}, f: nil,
+			cmd: words{"fileOp", "-r", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name(), "--ignore", "anotherRule"}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: nil,
 		},
@@ -838,7 +838,7 @@ func TestFileArgs(t *testing.T) {
 		}
 		expectedFileMap := make(map[string]bool)
 		for _, arg := range tc.args {
-			expectedFileMap[path.Base(arg)] = false
+			expectedFileMap[filepath.Base(arg)] = false
 		}
 		it := req.Files.Entries()
 		for it.Next() {

cli/responseemitter_test.go

@@ -42,7 +42,7 @@ func (tc tcCloseWithError) Run(t *testing.T) {
 
 func TestCloseWithError(t *testing.T) {
 	tcs := []tcCloseWithError{
-		tcCloseWithError{
+		{
 			stdout:   bytes.NewBuffer(nil),
 			stderr:   bytes.NewBuffer(nil),
 			exStdout: "a\n",
@@ -54,7 +54,7 @@ func TestCloseWithError(t *testing.T) {
 				re.Emit("b")
 			},
 		},
-		tcCloseWithError{
+		{
 			stdout:   bytes.NewBuffer(nil),
 			stderr:   bytes.NewBuffer(nil),
 			exStdout: "a\n",

cli/run_test.go

@@ -11,7 +11,7 @@ import (
 
 var root = &cmds.Command{
 	Subcommands: map[string]*cmds.Command{
-		"test": &cmds.Command{
+		"test": {
 			Run: func(req *cmds.Request, re cmds.ResponseEmitter, e cmds.Environment) error {
 				err := cmds.EmitOnce(re, 42)
 

command_test.go

@@ -130,8 +130,8 @@ func TestResolving(t *testing.T) {
 func TestWalking(t *testing.T) {
 	cmdA := &Command{
 		Subcommands: map[string]*Command{
-			"b": &Command{},
-			"B": &Command{},
+			"b": {},
+			"B": {},
 		},
 	}
 	i := 0
@@ -181,7 +181,7 @@ func TestPostRun(t *testing.T) {
 	defer cancel()
 
 	var testcases = []postRunTestCase{
-		postRunTestCase{
+		{
 			length:      3,
 			err:         nil,
 			emit:        []interface{}{7},