feat(Command): add status for the helptext #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
schomatis/feat/cmds-status
branch
from
e8e23f7
to
afaf21a
Compare
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 18, 2022
Added programmatic state annotation introduced in ipfs/go-ipfs-cmds#225 for already deprecated / experimental commands.
lidel
added a commit
to ipfs/ipfs-docs
that referenced
this pull request
Mar 18, 2022
Leverages Status field from ipfs/go-ipfs-cmds#225 ipfs/kubo#8802 and uses that information while generating HTTP RPC API reference docs.
This was referenced Mar 18, 2022
Closed
lidel
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Thank you @schomatis, I took it for a spin in ipfs/kubo#8802 and ipfs/ipfs-docs#1086, and it works perfectly 👌
Comment on lines
+502
to
+507
| case cmds.Deprecated: | ||
| return "DEPRECATED, command will be removed in the future" | ||
| case cmds.Experimental: | ||
| return "EXPERIMENTAL, command may change in future releases" | ||
| case cmds.Removed: | ||
| return "REMOVED, command is no longer available" |
There was a problem hiding this comment.
IF this text looks ok, then we can merge and ship this.
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 22, 2022
* feat(cmds): add deprecated and experimental status Added programmatic state annotation introduced in ipfs/go-ipfs-cmds#225 for already deprecated / experimental commands. * chore: go-ipfs-cmds v0.7.0 Co-authored-by: Lucas Molas <schomatis@gmail.com>
lidel
added a commit
to ipfs/ipfs-docs
that referenced
this pull request
Apr 21, 2022
Leverages Status field from ipfs/go-ipfs-cmds#225 ipfs/kubo#8802 and uses that information while generating HTTP RPC API reference docs.
lidel
added a commit
to ipfs/ipfs-docs
that referenced
this pull request
Apr 21, 2022
Leverages Status field from ipfs/go-ipfs-cmds#225 ipfs/kubo#8802 and uses that information while generating HTTP RPC API reference docs.
hannahhoward
pushed a commit
to filecoin-project/kubo-api-client
that referenced
this pull request
Jun 19, 2023
* feat(cmds): add deprecated and experimental status Added programmatic state annotation introduced in ipfs/go-ipfs-cmds#225 for already deprecated / experimental commands. * chore: go-ipfs-cmds v0.7.0 Co-authored-by: Lucas Molas <schomatis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of this patch is trivial; this review is more about adjusting to the desired presentation (if there are aesthetic changes needed an example of the desired output would be useful).
Closes #93.