Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate status codes #14

Merged
merged 3 commits into from
Sep 22, 2022
Merged

fix: validate status codes #14

merged 3 commits into from
Sep 22, 2022

Conversation

justindotpub
Copy link
Collaborator

Closes #13

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but mind addressibg below @justincjohnson ?

redirects.go Outdated Show resolved Hide resolved
redirects.go Outdated Show resolved Hide resolved
redirects.go Outdated Show resolved Hide resolved
redirects.go Outdated Show resolved Hide resolved
@justindotpub
Copy link
Collaborator Author

@lidel All feedback has been addressed and pushed.

@justindotpub
Copy link
Collaborator Author

FYI, I've rebased the other PRs with these changes as well.

@lidel lidel changed the title Validate status codes fix: validate status codes Sep 22, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, simplified it even further.

@lidel lidel merged commit 0fce9c8 into ipfs:main Sep 22, 2022
@justindotpub justindotpub deleted the justincjohnson/validate-status branch September 22, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate status codes
2 participants