Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size() shouldn't return a constant. #7

Closed
Stebalien opened this issue Jul 3, 2017 · 1 comment · Fixed by #31
Closed

Size() shouldn't return a constant. #7

Stebalien opened this issue Jul 3, 2017 · 1 comment · Fixed by #31

Comments

@Stebalien
Copy link
Member

So, Node.Size() means different things in different places (ipfs/go-ipld-format#12). However, returning arbitrary constants (13, 42, etc...) as we're doing here is, unambiguously, wrong...

I know this is currently "not implemented" but this fact should probably be recorded in an issue so we can make sure to fix this when we actually decide on the semantics of Node.Size().
@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Oct 17, 2017
@sameer
Copy link
Contributor

sameer commented Dec 18, 2018

This can be partially fixed after #28, since the raw data is stored after the first call to RawData().

sameer added a commit to sameer/go-ipld-git that referenced this issue Dec 30, 2018
@sameer
Use rawdata length for size, fixes ipfs#7
46055ce
@sameer sameer mentioned this issue Dec 30, 2018
Merged
magik6k added a commit that referenced this issue Jan 4, 2019
@magik6k
Merge pull request #31 from sameer/realsize
bd8ed46 
Use rawdata length for size, fixes #7
@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use rawdata length for size, fixes #7 sameer/go-ipld-git
3 participants
@Stebalien @whyrusleeping @sameer