feat: export binary from @helia/interop #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
approved these changes
Jan 16, 2024
|
|
||
| import { spawn } from 'node:child_process' | ||
|
|
||
| const test = spawn('npx', ['aegir', 'test']) |
There was a problem hiding this comment.
I don't think we need npx here but not sure of the hassle of getting aegir binary
There was a problem hiding this comment.
aegir is installed as a dep - we need to find the binary so we could assume the location with:
spawn('node', ['node_modules', '.bin', 'aegir', 'test'])or use npx and let npm figure it out.
To prevent things like transient deps breaking Kubo interop tests, export a bin to allow installing the interop tests from npm and running them in an easy-to-digest way.
achingbrain
force-pushed
the
fix/export-interop-bin
branch
from
5aa0c29
to
256e35b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent things like transient deps breaking Kubo interop tests,
export a bin to allow installing the interop tests from npm and
running them in an easy-to-digest way.