fix!: remove gossipsub from default libp2p services #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not required to IPFS things, it's a large chunk of code and it's quite CPU intensive so do not bundle it by default. People can still configure themselves if they need it.
achingbrain
force-pushed
the
fix/remove-gossipsub
branch
from
8775d9d
to
fa67437
Compare
Merged
|
Nice. Do we track the bundle size at all? |
|
Not actively, we used to rely on https://bundlephobia.com for this but it doesn't work with exports maps 😭 |
|
Just discovered https://packagephobia.com - this one seems to work: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not required to IPFS things, it's a large chunk of code and it's quite CPU intensive so do not bundle it by default.
People can still configure themselves if they need it.