Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow contentTypeParser with Helia instance #427

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Feb 9, 2024

fixes an issue where createVerifiedFetch would not allow both:

  • a custom Helia instance
  • a custom contentTypeParser

This is needed in both helia-http-gateway & helia-service-worker-gateway because the helia instance needs to be controlled by the application

@SgtPooki SgtPooki requested a review from a team as a code owner February 9, 2024 21:50
@SgtPooki SgtPooki changed the title fix: allow contentTypeParser with helia instance fix: allow contentTypeParser with Helia instance Feb 9, 2024
@SgtPooki SgtPooki merged commit 3283a5c into main Feb 9, 2024
19 checks passed
@SgtPooki SgtPooki deleted the fix/allow-custom-type-parser-and-helia-instance branch February 9, 2024 22:19
@achingbrain achingbrain mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant