fix: respect the IPNS TTL field #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the `@libp2p/record` `timeReceived` property and the `.ttl` field of the IPNS Record to calcuate the TTL of the record separately from the record EOL. This was going to be a push to #473 but it was merged prematurely.
SgtPooki
approved these changes
Apr 3, 2024
| // add the local record to our list of resolved record, and also | ||
| // search the routing for updates - the most up to date record will be | ||
| // returned | ||
| records.push(record) |
There was a problem hiding this comment.
nit: we are calling ipnsValidator twice for these records. it would be nice to consolidate the record processing logic
There was a problem hiding this comment.
Agreed, there's no point in re-validating the cached record, but it takes several orders of magnitude longer to look up a record than it does to validate it so any performance gain would be unnoticeable.
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
@libp2p/recordtimeReceivedproperty and the.ttlfield of the IPNS Record to calcuate the TTL of the record separately from the record EOL.This was going to be a push to #473 but it was merged prematurely.
Fixes #479
Change checklist