Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove wants from wantlist when multiple block retrievers are used #491

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: remove wants from wantlist when multiple block retrievers are used #491

merged 2 commits into from
Apr 9, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Apr 9, 2024 •
edited
Loading

Fixes a bug where sometimes a wanted CID was not removed from the wantlist when it was retrieved by an alternative block retriever.

Also switches to using events for block/presence arrival to remove shared promises.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: ensure wants are remove from wantlist
4ca7597 
Fixes a bug where sometimes a wanted CID was not removed from the
wantlist.

Also switches to using events for block/presence arrival to remove
shared promises.
@achingbrain achingbrain requested a review from a team as a code owner April 9, 2024 10:59
@achingbrain achingbrain changed the title fix: ensure wants are remove from wantlist fix: ensure wants are remove from wantlist when multiple block retrievers are used Apr 9, 2024
@achingbrain achingbrain changed the title fix: ensure wants are remove from wantlist when multiple block retrievers are used fix: remove wants from wantlist when multiple block retrievers are used Apr 9, 2024
@achingbrain achingbrain merged commit b1c761d into main Apr 9, 2024
18 checks passed
@achingbrain achingbrain deleted the fix/ensure-wants-are-removed branch April 9, 2024 11:50
@achingbrain achingbrain mentioned this pull request Apr 9, 2024
Merged
@SgtPooki SgtPooki mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain