Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I constantly get ipfs api accessible/inaccessible chrome notifications when i run something cpu and memory intensive on all cores. #1091

Closed
kotenok2000 opened this issue Aug 22, 2022 · 7 comments · Fixed by #1123
Assignees
Labels
exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up
Milestone

Comments

@kotenok2000
Copy link

kotenok2000 commented Aug 22, 2022

Describe the bug
A clear and concise description of what the bug is.
I get ipfs api accessible/inaccessible chrome notifications when i run something cpu and memory intensive on all cores.
To Reproduce
Steps to reproduce the behavior:

  1. install ipfs desktop
  2. Run boinc on all cores and run virtual machine with 4 gb ram allocated.
  3. install ipfs companion and open lots of tabs.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Microsoft Windows [Version 10.0.22000.856]
  • Browser: chrome
  • Version: 104.0.5112.102

Additional context
Add any other context about the problem here.

@kotenok2000 kotenok2000 added the need/triage Needs initial labeling and prioritization label Aug 22, 2022
@SgtPooki
Copy link
Member

Thanks for submitting this issue @kotenok2000.

I believe this issue is with chrome or your computer specifically and not ipfs, but we may be able to investigate further if you can provide further information:

  • Can you share your total memory allocation when these errors occur?
    • Do you have any extra memory?
    • Are other network operations or browser plugins working when in this state?

@SgtPooki SgtPooki added need/author-input Needs input from the original author and removed need/triage Needs initial labeling and prioritization labels Aug 22, 2022
@kotenok2000
Copy link
Author

No. I have 16 gb and 91% is used.
It happens when browser lags.

@github-actions
Copy link
Contributor

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

@kotenok2000
Copy link
Author

What more information do you need?

@SgtPooki
Copy link
Member

@kotenok2000 Thanks for that information.

It seems like you're running out of resources for what you're trying to do. ipfs-companion has logic where it polls the running ipfs daemon every 3 seconds, to make sure the daemon is available. I imagine updating that logic to slow the polling time as requests are returning more slowly could help solve your and any others' similar issues.

However, for now, you can change that setting in ipfs-companion settings. See if that helps resolve your issue.

You could also start up the kubo daemon instead of IPFS Desktop too, to see if this helps your more resource intensive usecase.

I'll leave this issue open for making that polling logic smarter, but this is blocked until #666 is resolved.

@SgtPooki SgtPooki added status/blocked Unable to be worked further until needs are met exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now and removed need/author-input Needs input from the original author kind/stale labels Aug 29, 2022
@ipfs ipfs deleted a comment from welcome bot Oct 18, 2022
@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up and removed status/blocked Unable to be worked further until needs are met P3 Low: Not priority right now labels Nov 24, 2022
@lidel lidel added this to the v2.21 milestone Nov 24, 2022
@lidel
Copy link
Member

lidel commented Nov 24, 2022

It is unblocked (merged #1054).

@whizzzkid thoughts on solving the underlying annoyance and stopping online/offline notifications?

We could either:

  • stop showing system notification when node state changes by removing notify calls from this function
  • (if you feel it is useful at all) add a new toggle on Options page ⚙️, but it should be turned off by default.

My vote would be to simply remove these two notifications – user feedback has been consistent that they are annoying.

@lidel lidel modified the milestones: v2.21, v2.20 Nov 24, 2022
@whizzzkid whizzzkid self-assigned this Dec 21, 2022
@whizzzkid
Copy link
Contributor

@lidel I managed to miss this notification, I created a PR #1123 to kill these notifications. However there is already a toggle to turn on/off all extension notifications which seems to work. Maybe we can extend this to make this extension more granular.

Screenshot 2022-12-21 at 12 20 43 AM

It could inherit design from how @SgtPooki's work on tracking toggle's work out, but what I was thing was:

  • Notifications <turn all on or off, we already have this>
    • Node State Change
    • Copy/Paste
    • News/Notification/Product Updates
    • etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Archived in project
4 participants