Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web+fs:/ links are wrongly redirected to public gateways #150

Closed
RndFooBar opened this issue Sep 25, 2016 · 2 comments
Closed

web+fs:/ links are wrongly redirected to public gateways #150

RndFooBar opened this issue Sep 25, 2016 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) status/blocked/missing-api Blocked by missing API

Comments

@RndFooBar
Copy link

RndFooBar commented Sep 25, 2016

The addon redirects web+fs:/ links, when requested with AJAX, to public gateways even though the custom gateway is available.

How to reproduce:

  1. Open test.html with firefox
  2. The Web Console indicates (through an error of Cross-Origin Request) that the file https://ipfs.io/ipfs/QmU[...]3Nn was requested

Expected Behaviour:

The custom gateway should have been used.
The requested file should have been: http://localhost:8080/ipfs/QmU[...]3Nn (with default settings)

@lidel
Copy link
Member

lidel commented Sep 26, 2016

Thank you for reporting this.

This seems to be a limitation of old SDK (security policy blocks request before we replace it with local one).

Let's leave this bug open until it can be revisited after WebExtension rewrite is done (#20) and API for custom protocols is introduced (#164)

@lidel lidel added kind/bug A bug in existing code (including security flaws) status/blocked/missing-api Blocked by missing API labels Sep 26, 2016
@lidel
Copy link
Member

lidel commented Oct 15, 2017

This is no longer reproducible under WebExtension version (#20):
we do not have real protocol handler anymore, only a set of hacks that simulate it (see #164).

I am closing this one, if at some point in future a similar use case could be formulated against WebExtension version, it should be a new issue.

@lidel lidel closed this as completed Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/blocked/missing-api Blocked by missing API
Projects
None yet
Development

No branches or pull requests

2 participants